Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase robot timeout to 120s in test_vnc #153

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

hbatagelo
Copy link
Contributor

This PR gives more time for the robot process in test_vnc to complete and shutdown gracefully.

@hbatagelo hbatagelo requested a review from a team as a code owner November 12, 2024 18:08
@hbatagelo hbatagelo enabled auto-merge November 12, 2024 18:15
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (31dbc8a) to head (575d340).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   68.37%   68.49%   +0.11%     
==========================================
  Files          16       16              
  Lines         876      876              
  Branches      126       89      -37     
==========================================
+ Hits          599      600       +1     
  Misses        251      251              
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks "at worst harmless". The tests have been failing a while and seem unrelated

@hbatagelo hbatagelo added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 2e72fd7 Nov 13, 2024
10 of 20 checks passed
@hbatagelo hbatagelo deleted the increase-timeout-for-vnc-test branch November 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants